Ajout de tests d'inscriptions.

app/Resources/FOSUserBundle/config/validation.xml

@@ -0,0 +1,160 @@
+<?xml version="1.0" ?>
+<constraint-mapping xmlns="http://symfony.com/schema/dic/constraint-mapping"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="http://symfony.com/schema/dic/constraint-mapping
+        http://symfony.com/schema/dic/services/constraint-mapping-1.0.xsd">
+
+    <class name="FOS\UserBundle\Model\User">
+
+        <constraint name="FOS\UserBundle\Validator\Unique">
+            <option name="property">usernameCanonical</option>
+            <option name="message">The username is already used</option>
+            <option name="groups">
+                <value>Registration</value>
+                <value>Profile</value>
+            </option>
+        </constraint>
+
+        <constraint name="FOS\UserBundle\Validator\Unique">
+            <option name="property">emailCanonical</option>
+            <option name="message">The email is already used</option>
+            <option name="groups">
+                <value>Registration</value>
+                <value>Profile</value>
+            </option>
+        </constraint>
+
+        <property name="username">
+            <constraint name="NotBlank">
+                <option name="message">Please enter a username</option>
+                <option name="groups">
+                    <value>Registration</value>
+                    <value>Profile</value>
+                </option>
+            </constraint>
+            <constraint name="MinLength">
+                <option name="limit">6</option>
+                <option name="message">The username is too short</option>
+                <option name="groups">
+                    <value>Registration</value>
+                    <value>Profile</value>
+                </option>
+            </constraint>
+            <constraint name="MaxLength">
+                <option name="limit">32</option>
+                <option name="message">The username is too long</option>
+                <option name="groups">
+                    <value>Registration</value>
+                    <value>Profile</value>
+                </option>
+            </constraint>
+        </property>
+
+        <property name="email">
+            <constraint name="NotBlank">
+                <option name="message">Please enter an email</option>
+                <option name="groups">
+                    <value>Registration</value>
+                    <value>Profile</value>
+                </option>
+            </constraint>
+            <constraint name="MinLength">
+                <option name="limit">2</option>
+                <option name="message">The email is too short</option>
+                <option name="groups">
+                    <value>Registration</value>
+                    <value>Profile</value>
+                </option>
+            </constraint>
+            <constraint name="MaxLength">
+                <option name="limit">255</option>
+                <option name="message">The email is too long</option>
+                <option name="groups">
+                    <value>Registration</value>
+                    <value>Profile</value>
+                </option>
+            </constraint>
+            <constraint name="Email">
+                <option name="message">The email is not valid</option>
+                <option name="groups">
+                    <value>Registration</value>
+                    <value>Profile</value>
+                </option>
+            </constraint>
+        </property>
+
+        <property name="plainPassword">
+            <constraint name="NotBlank">
+                <option name="message">Please enter a password</option>
+                <option name="groups">Registration</option>
+            </constraint>
+            <constraint name="MinLength">
+                <option name="limit">2</option>
+                <option name="message">The password is too short</option>
+                <option name="groups">
+                    <value>Registration</value>
+                    <value>Profile</value>
+                </option>
+            </constraint>
+        </property>
+    </class>
+
+    <class name="FOS\UserBundle\Form\Model\CheckPassword">
+        <constraint name="FOS\UserBundle\Validator\Password">
+            <option name="passwordProperty">current</option>
+            <option name="userProperty">user</option>
+            <option name="groups">
+                <value>ChangePassword</value>
+                <value>Profile</value>
+            </option>
+        </constraint>
+    </class>
+
+    <class name="FOS\UserBundle\Form\Model\ChangePassword">
+        <property name="new">
+            <constraint name="NotBlank">
+                <option name="message">Please enter a new password</option>
+                <option name="groups">ChangePassword</option>
+            </constraint>
+            <constraint name="MinLength">
+                <option name="limit">2</option>
+                <option name="message">The new password is too short</option>
+                <option name="groups">ChangePassword</option>
+            </constraint>
+        </property>
+    </class>
+
+    <class name="FOS\UserBundle\Form\Model\ResetPassword">
+        <property name="new">
+            <constraint name="NotBlank">
+                <option name="message">Please enter a new password</option>
+                <option name="groups">ResetPassword</option>
+            </constraint>
+            <constraint name="MinLength">
+                <option name="limit">2</option>
+                <option name="message">The new password is too short</option>
+                <option name="groups">ResetPassword</option>
+            </constraint>
+        </property>
+    </class>
+
+    <class name="FOS\UserBundle\Model\Group">
+        <property name="name">
+            <constraint name="NotBlank">
+                <option name="message">Please enter a name</option>
+                <option name="groups">Registration</option>
+            </constraint>
+            <constraint name="MinLength">
+                <option name="limit">2</option>
+                <option name="message">The name is too short</option>
+                <option name="groups">Registration</option>
+            </constraint>
+            <constraint name="MaxLength">
+                <option name="limit">255</option>
+                <option name="message">The name is too long</option>
+                <option name="groups">Registration</option>
+            </constraint>
+        </property>
+    </class>
+
+</constraint-mapping>

catalog.xml

@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<catalog xmlns="urn:oasis:names:tc:entity:xmlns:xml:catalog" prefer="system">
+    <nextCatalog catalog="nbproject/private/retriever/catalog.xml"/>
+</catalog>

src/Muzich/CoreBundle/Resources/config/validation.yml

@@ -0,0 +1,7 @@
+##
+
+Muzich\CoreBundle\Entity\User:
+  properties:
+    username:
+      - MinLength: { limit: 3}
+      - MaxLength: { limit: 32}

src/Muzich/CoreBundle/Tests/Controller/IndexControllerTest.php

@@ -6,7 +6,7 @@ use Muzich\CoreBundle\lib\FunctionalTest;
 
 class IndexControllerTest extends FunctionalTest
 {
-  public function testIdentification()
+  public function testIdentificationSuccess()
   {
     /**
      * Test de l'identification de paul
@@ -39,7 +39,33 @@ class IndexControllerTest extends FunctionalTest
     $this->assertEquals('paul', $user->getUsername());
   }
   
-  public function testRegistration()
+  public function testIdentificationFail()
+  {
+    /**
+     * Test de l'identification de paul, avec erreur
+     */
+    $this->client = self::createClient();
+
+    $this->crawler = $this->client->request('GET', $this->generateUrl('index'));
+    $this->isResponseSuccess();
+
+    $this->assertEquals('anon.', $this->getUser());
+
+    $form = $this->selectForm('form[action="'.$this->generateUrl('fos_user_security_check').'"] input[type="submit"]');
+    $form['_username'] = 'paul';
+    $form['_password'] = 'toorr';
+    $form['_remember_me'] = true;
+    $this->submit($form);
+
+    $this->isResponseRedirection();
+    $this->followRedirection();
+    $this->isResponseSuccess();
+
+    $user = $this->getUser();
+    $this->assertEquals('anon.', $this->getUser());
+  }
+  
+  public function testRegistrationSuccess()
   {
     /**
      * Inscription d'un utilisateur
@@ -59,27 +85,74 @@ class IndexControllerTest extends FunctionalTest
     $this->exist('form[action="'.$url.'"] input[id="fos_user_registration_form_plainPassword_second"]');
     $this->exist('form[action="'.$url.'"] input[type="submit"]');
     
-    $form = $this->selectForm('form[action="'.$url.'"] input[type="submit"]');
-    $form['fos_user_registration_form[username]'] = 'raoul';
-    $form['fos_user_registration_form[email]'] = 'raoul.45gf64z@gmail.com';
-    $form['fos_user_registration_form[plainPassword][first]'] = 'toor';
-    $form['fos_user_registration_form[plainPassword][second]'] = 'toor';
-    $this->submit($form);
+    $this->validate_registrate_user_form(
+      $this->selectForm('form[action="'.$url.'"] input[type="submit"]'), 
+      'raoula', 
+      'raoul.45gf64z@gmail.com', 
+      'toor',
+      'toor'
+    );
     
     $this->isResponseRedirection();
     $this->followRedirection();
     $this->isResponseSuccess();
 
     $user = $this->getUser();
-    $this->assertEquals('raoul', $user->getUsername());
+    $this->assertEquals('raoula', $user->getUsername());
     
-    /*
-     * TODO: Vérifier les données en base
-     */
+    // L'utilisateur est enregistré, il doit donc être en base
+    $db_user = $this->getDoctrine()->getRepository('MuzichCoreBundle:User')
+      ->findOneByUsername('raoula')
+    ;
+    
+    $this->assertTrue(!is_null($db_user));
+    if ($db_user)
+    {
+      $this->assertEquals('raoula', $db_user->getUsername());
+    }
   }
   
-  /*
-   * TODO: Vérifier le comportement des formulaires lorsque l'on rentre de mauvaises données
-   */
+  public function testRegistrationFailure()
+  {
+    
+    /**
+     * Inscription d'un utilisateur
+     */
+    $this->client = self::createClient();
+
+    // Mots de passe différents
+    $this->procedure_registration_failure(
+      'raoulb', 
+      'raoulb.def4v65sds@gmail.com', 
+      'toor', 
+      'toorr'
+    );
+
+//    // Pseudo trop court
+//    $this->procedure_registration_failure(
+//      'ra', 
+//      'raoulb.def4v65sds@gmail.com', 
+//      'toor', 
+//      'toor'
+//    );
+//    
+//    // Pseudo trop long
+//    $this->procedure_registration_failure(
+//      'raouuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuu'
+//         .'uuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuu'
+//         .'uuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuul', 
+//      'raoulb.def4v65sds@gmail.com', 
+//      'toor', 
+//      'toor'
+//    );
+
+    // Email invalide
+    $this->procedure_registration_failure(
+      'raoulc', 
+      'raoulb.def4v65sds@gmail', 
+      'toor', 
+      'toor'
+    );
+  }
   
 }

src/Muzich/CoreBundle/lib/FunctionalTest.php

@@ -60,6 +60,52 @@ class FunctionalTest extends WebTestCase
     $this->assertEquals($login, $user->getUsername());
   }
   
+  protected function validate_registrate_user_form($form, $username, $email, $pass1, $pass2)
+  {
+    $form['fos_user_registration_form[username]'] = $username;
+    $form['fos_user_registration_form[email]'] = $email;
+    $form['fos_user_registration_form[plainPassword][first]'] = $pass1;
+    // Un des mots de passe est incorrect
+    $form['fos_user_registration_form[plainPassword][second]'] = $pass2;
+    $this->submit($form);
+  }
+  
+  protected function procedure_registration_failure($username, $email, $pass1, $pass2)
+  {
+    $this->crawler = $this->client->request('GET', $this->generateUrl('index'));
+    $this->isResponseSuccess();
+    $this->assertEquals('anon.', $this->getUser());
+    
+    $url = $this->generateUrl('register');
+    // Les mots de passes sont différents
+    $this->validate_registrate_user_form(
+      $this->selectForm('form[action="'.$url.'"] input[type="submit"]'), 
+      $username, 
+      $email, 
+      $pass1,
+      $pass2
+    );
+    
+    $this->isResponseSuccess();
+
+    if ('anon.' === ($user = $this->getUser()))
+    {
+      // Nous ne sommes pas identifiés
+      $this->assertEquals('anon.', $user);
+
+      // L'utilisateur n'est pas enregistré, il ne doit donc pas être en base
+      $db_user = $this->getDoctrine()->getRepository('MuzichCoreBundle:User')
+        ->findOneByUsername($username)
+      ;
+
+      $this->assertTrue(is_null($db_user));
+    }
+    else
+    {
+      $this->assertTrue(false);
+    }
+  }
+  
   /**
    * Generates a URL from the given parameters.
    *