Refactorisation moderation tags.

src/Muzich/AdminBundle/Controller/ModerateController.php

 //use Muzich\CoreBundle\Util\TagLike;
 use Muzich\CoreBundle\Entity\UsersTagsFavorites;
 use Muzich\CoreBundle\Entity\GroupsTagsFavorites;
+use Muzich\CoreBundle\Managers\TagManager;
 
 class ModerateController extends Controller
 {
       }
     }
     
-    if (!($tag = $this->getDoctrine()->getRepository('MuzichCoreBundle:Tag')->findOneBy(array(
-      'id'         => $tag_id,
-      'tomoderate' => true
-    ))))
+    $tagManager = new TagManager();
+    if (!$tagManager->moderateTag($this->getDoctrine(), $tag_id, true))
     {
       return $this->jsonResponse(array(
         'status'  => 'error',
       ));
     }
     
-    $tag->setTomoderate(false);
-    $tag->setPrivateids(null);
-    $this->getDoctrine()->getEntityManager()->persist($tag);
-    $this->getDoctrine()->getEntityManager()->flush();
-    
     return $this->jsonResponse(array(
       'status' => 'success'
     ));
       }
     }
     
-    if (!($tag = $this->getDoctrine()->getRepository('MuzichCoreBundle:Tag')->findOneBy(array(
-      'id'         => $tag_id,
-      'tomoderate' => true
-    ))))
+    $tagManager = new TagManager();
+    if (!$tagManager->moderateTag($this->getDoctrine(), $tag_id, false))
     {
       return $this->jsonResponse(array(
         'status'  => 'error',
       ));
     }
     
-    $this->getDoctrine()->getEntityManager()->remove($tag);
-    $this->getDoctrine()->getEntityManager()->flush();
-    
     return $this->jsonResponse(array(
       'status' => 'success'
     ));
     }
     $tag_new_id = $tag_array[0];
     
-    if (
-      !($tag = $this->getDoctrine()->getRepository('MuzichCoreBundle:Tag')->findOneBy(array(
-        'id'         => $tag_id,
-        'tomoderate' => true
-      )))
-      || !($new_tag = $this->getDoctrine()->getRepository('MuzichCoreBundle:Tag')->findOneById($tag_new_id))
-    )
+    $tagManager = new TagManager();
+    if (!$tagManager->moderateTag($this->getDoctrine(), $tag_id, false, $tag_new_id))
     {
       return $this->jsonResponse(array(
         'status'  => 'error',
       ));
     }
     
-    /*
-     * Trois cas de figures ou sont utilisés les tags
-     *  * Sur un élément
-     *  * Tag favori
-     *  * Tag d'un groupe
-     */
-    $em = $this->getDoctrine()->getEntityManager();
-    
-    // Sur un élément
-    foreach ($elements = $this->getDoctrine()->getEntityManager()->createQuery("
-      SELECT e, t FROM MuzichCoreBundle:Element e
-      JOIN e.tags t
-      WHERE t.id  = :tid
-    ")
-      ->setParameter('tid', $tag_id)
-      ->getResult() as $element)
-    {
-      // Pour chaque elements lié a ce tag
-      // On ajoute un lien vers le nouveau tag si il n'en n'a pas déjà
-      if (!$element->hasTag($new_tag))
-      {
-        $element->addTag($new_tag);
-        $em->persist($element);
-      }
-    }
-    
-    // Tag favoris
-    foreach ($favorites = $this->getDoctrine()->getEntityManager()->createQuery("
-      SELECT f FROM MuzichCoreBundle:UsersTagsFavorites f
-      WHERE f.tag  = :tid
-    ")
-      ->setParameter('tid', $tag_id)
-      ->getResult() as $fav)
-    {
-      // Pour chaque favoris utilisant ce tag on regarde si l'utilisateur
-      // n'a pas déjà le nouveau tag en favoris.
-      if (!$this->getDoctrine()->getEntityManager()->createQuery("
-        SELECT COUNT(f.id) FROM MuzichCoreBundle:UsersTagsFavorites f
-        WHERE f.tag  = :tid AND f.user = :uid
-      ")
-      ->setParameters(array('tid' => $tag_new_id, 'uid' => $fav->getUser()->getId()))
-      ->getSingleScalarResult())
-      {
-        $new_fav = new UsersTagsFavorites();
-        $new_fav->setTag($new_tag);
-        $new_fav->setUser($fav->getUser());
-        $new_fav->setPosition($fav->getPosition());
-        $em->persist($new_fav);
-      }
-      $em->remove($fav);
-    }
-    
-    // groupe
-    foreach ($this->getDoctrine()->getEntityManager()->createQuery("
-      SELECT f FROM MuzichCoreBundle:GroupsTagsFavorites f
-      WHERE f.tag  = :tid
-    ")
-      ->setParameter('tid', $tag_id)
-      ->getResult() as $fav)
-    {
-      // Pour chaque favoris utilisant ce tag on regarde si le groupe
-      // n'a pas déjà le nouveau tag en favoris.
-      if (!$this->getDoctrine()->getEntityManager()->createQuery("
-        SELECT COUNT(f.id) FROM MuzichCoreBundle:GroupsTagsFavorites f
-        WHERE f.tag  = :tid AND f.group = :gid
-      ")
-      ->setParameters(array('tid' => $tag_new_id, 'gid' => $fav->getGroup()->getId()))
-      ->getSingleScalarResult())
-      {
-        $new_fav = new GroupsTagsFavorites();
-        $new_fav->setTag($new_tag);
-        $new_fav->setGroup($fav->getGroup());
-        $new_fav->setPosition($fav->getPosition());
-        $em->persist($new_fav);
-      }
-      $em->remove($fav);
-    }
-    
-    $em->remove($tag);
-    $em->flush();
-    
     return $this->jsonResponse(array(
       'status' => 'success'
     ));
+    
   }
   
 }

src/Muzich/CoreBundle/Managers/TagManager.php

 use FOS\UserBundle\Util\CanonicalizerInterface;
 use Symfony\Bundle\DoctrineBundle\Registry;
 use Muzich\CoreBundle\Util\StrictCanonicalizer;
+use Muzich\CoreBundle\Entity\UsersTagsFavorites;
+use Muzich\CoreBundle\Entity\GroupsTagsFavorites;
 
 /**
  * 
     }
   }
   
+  protected function replaceTagByAnother(EntityManager $em, $tag, $new_tag)
+  {
+    /*
+     * Trois cas de figures ou sont utilisés les tags
+     *  * Sur un élément
+     *  * Tag favori
+     *  * Tag d'un groupe
+     */
+    
+    // Sur un élément
+    foreach ($elements = $em->createQuery("
+      SELECT e, t FROM MuzichCoreBundle:Element e
+      JOIN e.tags t
+      WHERE t.id  = :tid
+    ")
+      ->setParameter('tid', $tag->getId())
+      ->getResult() as $element)
+    {
+      // Pour chaque elements lié a ce tag
+      // On ajoute un lien vers le nouveau tag si il n'en n'a pas déjà
+      if (!$element->hasTag($new_tag))
+      {
+        $element->addTag($new_tag);
+        $em->persist($element);
+      }
+    }
+    
+    // Tag favoris
+    foreach ($favorites = $em->createQuery("
+      SELECT f FROM MuzichCoreBundle:UsersTagsFavorites f
+      WHERE f.tag  = :tid
+    ")
+      ->setParameter('tid', $tag->getId())
+      ->getResult() as $fav)
+    {
+      // Pour chaque favoris utilisant ce tag on regarde si l'utilisateur
+      // n'a pas déjà le nouveau tag en favoris.
+      if (!$em->createQuery("
+        SELECT COUNT(f.id) FROM MuzichCoreBundle:UsersTagsFavorites f
+        WHERE f.tag  = :tid AND f.user = :uid
+      ")
+      ->setParameters(array('tid' => $new_tag->getId(), 'uid' => $fav->getUser()->getId()))
+      ->getSingleScalarResult())
+      {
+        $new_fav = new UsersTagsFavorites();
+        $new_fav->setTag($new_tag);
+        $new_fav->setUser($fav->getUser());
+        $new_fav->setPosition($fav->getPosition());
+        $em->persist($new_fav);
+      }
+      $em->remove($fav);
+    }
+    
+    // groupe
+    foreach ($em->createQuery("
+      SELECT f FROM MuzichCoreBundle:GroupsTagsFavorites f
+      WHERE f.tag  = :tid
+    ")
+      ->setParameter('tid', $tag->getId())
+      ->getResult() as $fav)
+    {
+      // Pour chaque favoris utilisant ce tag on regarde si le groupe
+      // n'a pas déjà le nouveau tag en favoris.
+      if (!$em->createQuery("
+        SELECT COUNT(f.id) FROM MuzichCoreBundle:GroupsTagsFavorites f
+        WHERE f.tag  = :tid AND f.group = :gid
+      ")
+      ->setParameters(array('tid' => $new_tag->getId(), 'gid' => $fav->getGroup()->getId()))
+      ->getSingleScalarResult())
+      {
+        $new_fav = new GroupsTagsFavorites();
+        $new_fav->setTag($new_tag);
+        $new_fav->setGroup($fav->getGroup());
+        $new_fav->setPosition($fav->getPosition());
+        $em->persist($new_fav);
+      }
+      $em->remove($fav);
+    }
+    
+    $em->remove($tag);
+    $em->flush();
+  }
+  
+  public function moderateTag(Registry $doctrine, $tag_id, $accept, $replacing_id = null)
+  {
+    if (($tag = $doctrine->getRepository('MuzichCoreBundle:Tag')->findOneBy(array(
+      'id'         => $tag_id,
+      'tomoderate' => true
+    ))))
+    {
+      if ($accept)
+      {
+        $tag->setTomoderate(false);
+        $tag->setPrivateids(null);
+        $doctrine->getEntityManager()->persist($tag);
+        $doctrine->getEntityManager()->flush();
+      }
+      else
+      {
+        if ($replacing_id)
+        {
+          // Si c'est un remplacement on envoit la sauce
+          if (!($new_tag = $doctrine->getRepository('MuzichCoreBundle:Tag')->findOneById($replacing_id)))
+          {
+            return false;
+          }
+          $this->replaceTagByAnother($doctrine->getEntityManager(), $tag, $new_tag);
+        }
+        else
+        {
+          $doctrine->getEntityManager()->remove($tag);
+          $doctrine->getEntityManager()->flush();
+        }
+        
+      }
+      return true;
+    }
+    else
+    {
+      return false;
+    }
+  }
+  
 }