début des tests fonctionnels pour playlist

src/Muzich/CoreBundle/Resources/config/security.yml

@@ -106,6 +106,7 @@ security:
         - { path: ^/(?:fr|en)/user, role: IS_AUTHENTICATED_ANONYMOUSLY }
         - { path: ^/(?:fr|en)/group, role: IS_AUTHENTICATED_ANONYMOUSLY }
         - { path: ^/(?:fr|en)/search, role: IS_AUTHENTICATED_ANONYMOUSLY }
+        - { path: ^/(?:fr|en)/playlist, role: IS_AUTHENTICATED_ANONYMOUSLY }
                                         
         - { path: ^/, roles: ROLE_USER }
         

src/Muzich/CoreBundle/Tests/Controller/PlaylistControllerTest.php

@@ -1,7 +1,196 @@
 <?php
 
-/*
- * To change this template, choose Tools | Templates
- * and open the template in the editor.
- */
-?>
+namespace Muzich\CoreBundle\Tests\Controller;
+
+use Muzich\CoreBundle\lib\FunctionalTest;
+use Muzich\CoreBundle\Tests\lib\Security\Context as SecurityContextTest;
+use Muzich\CoreBundle\Security\Context as SecurityContext;
+use Muzich\CoreBundle\Tests\lib\Security\ContextTestCases;
+
+class PlaylistControllerTest extends FunctionalTest
+{
+  
+  protected $security_context_test;
+  protected $tests_cases;
+  
+  protected function init()
+  {
+    $this->client = self::createClient();
+    $this->security_context_test = new SecurityContextTest($this->client, $this);
+    $this->tests_cases = new ContextTestCases($this->client, $this);
+  }
+  
+//  public function testActionsSecurityRoles()
+//  {
+//    $this->init();
+//    $this->checkProhibedActionsForAnonymous();
+//    $this->checkAutorizedsActionsForAnonymous();
+//  }
+  
+  protected function checkProhibedActionsForAnonymous()
+  {
+    $this->security_context_test->testUserCantMakeActionStatus( 
+      SecurityContext::ACTION_PLAYLIST_ADD_ELEMENT, 
+      SecurityContext::CONDITION_USER_NOT_CONNECTED,
+      true
+    );
+    
+    $this->security_context_test->testUserCantMakeActionStatus( 
+      SecurityContext::ACTION_PLAYLIST_UPDATE_ORDER, 
+      SecurityContext::CONDITION_USER_NOT_CONNECTED,
+      true
+    );
+    
+    $this->security_context_test->testUserCantMakeActionStatus( 
+      SecurityContext::ACTION_PLAYLIST_REMOVE_ELEMENT, 
+      SecurityContext::CONDITION_USER_NOT_CONNECTED,
+      true
+    );
+    
+    $this->security_context_test->testUserCantMakeActionStatus( 
+      SecurityContext::ACTION_PLAYLIST_CREATE, 
+      SecurityContext::CONDITION_USER_NOT_CONNECTED,
+      true
+    );
+    
+    $this->security_context_test->testUserCantMakeActionStatus( 
+      SecurityContext::ACTION_PLAYLIST_COPY, 
+      SecurityContext::CONDITION_USER_NOT_CONNECTED,
+      true
+    );
+    
+    $this->security_context_test->testUserCantMakeActionStatus( 
+      SecurityContext::ACTION_PLAYLIST_DELETE, 
+      SecurityContext::CONDITION_USER_NOT_CONNECTED,
+      true
+    );
+    
+    $this->security_context_test->testUserCantMakeActionStatus( 
+      SecurityContext::ACTION_PLAYLIST_UNPICK, 
+      SecurityContext::CONDITION_USER_NOT_CONNECTED,
+      true
+    );
+    
+    $this->security_context_test->testUserCantMakeActionStatus( 
+      SecurityContext::ACTION_PLAYLIST_PICK, 
+      SecurityContext::CONDITION_USER_NOT_CONNECTED,
+      true
+    );
+  }
+  
+  protected function checkAutorizedsActionsForAnonymous()
+  {
+    $this->security_context_test->testUserCantMakeActionStatus( 
+      SecurityContext::ACTION_PLAYLIST_SHOW, 
+      SecurityContext::CONDITION_USER_NOT_CONNECTED,
+      false
+    );
+    
+    $this->security_context_test->testUserCantMakeActionStatus( 
+      SecurityContext::ACTION_PLAYLIST_DATA_AUTOPLAY, 
+      SecurityContext::CONDITION_USER_NOT_CONNECTED,
+      false
+    );
+    
+    $this->security_context_test->testUserCantMakeActionStatus( 
+      SecurityContext::ACTION_PLAYLIST_ADD_PROMPT, 
+      SecurityContext::CONDITION_USER_NOT_CONNECTED,
+      false
+    );
+  }
+  
+//  public function testPlaylistsRead()
+//  {
+//    $this->init();
+//    $this->initReadContextData();
+//    
+//    $this->checkReadablePlaylistsForAnonymous();
+//    $this->checkReadablePlaylistsForConnected();
+//    $this->checkReadablePlaylistsForOwner();
+//  }
+  
+  protected function initReadContextData()
+  {
+    $this->users['bux'] = $this->findUserByUsername('bux');
+    $this->playlists['bux_1_pub'] = $this->findOneBy('Playlist', 'Un peu de basses ?');
+    $this->playlists['bux_2_priv'] = $this->findOneBy('Playlist', 'Ma playlist perso');
+    $this->playlists['bob_pub'] = $this->findOneBy('Playlist', 'A travers l\'espace');
+  }
+  
+  protected function checkReadablePlaylistsForAnonymous()
+  {
+    $this->checkReadPlaylists($this->users['bux'], array($this->playlists['bux_1_pub']));
+  }
+  
+  protected function checkReadPlaylists($user, $playlists)
+  {
+    $this->tests_cases->playlistsShow($user->getSlug());
+    $this->isResponseSuccess();
+    $this->checkReadPlaylistsDom($playlists);
+    
+    foreach ($playlists as $playlist)
+    {
+      $this->tests_cases->playlistShow($user->getSlug(), $playlist->getId());
+      $this->isResponseSuccess();
+      $this->checkReadPlaylist($playlist);
+    }
+  }
+  
+  protected function checkReadPlaylistsDom($playlists)
+  {
+    $this->outputDebug();
+    $this->assertEquals(count($playlists), $this->crawler->filter('ul.playlists li.playlist')->count());
+    foreach ($playlists as $playlist)
+    {
+      $this->exist('a[href="'.$this->generateUrl('playlist_datas_for_autoplay', array('playlist_id' => $playlist->getId())).'"]');
+    }
+  }
+  
+  protected function checkReadPlaylist($playlist)
+  {
+    $this->exist('h2:contains("'.$playlist->getName().'")');
+  }
+  
+  protected function checkReadablePlaylistsForConnected()
+  {
+    $this->connectUser('jean', 'toor');
+    $this->checkReadPlaylists($this->users['bux'], array($this->playlists['bux_1_pub']));
+    $this->disconnectUser();
+  }
+  
+  protected function checkReadablePlaylistsForOwner()
+  {
+    $this->connectUser('bux', 'toor');
+    $this->checkReadPlaylists($this->users['bux'], array(
+      $this->playlists['bux_1_pub'],
+      $this->playlists['bux_2_priv'],
+      $this->playlists['bob_pub'],
+    ));
+  }
+  
+  public function testPlaylistCreation()
+  {
+    $this->init();
+    $this->initCreateContextData();
+    $this->connectUser('joelle', 'toor');
+    
+    $this->playlists['joelle_1'] = $this->createPlaylistWithElement($this->elements['babylon']);
+    $this->checkReadPlaylists($this->users['joelle'], array($this->playlists['joelle_1']));
+  }
+  
+  protected function initCreateContextData()
+  {
+    $this->initReadContextData();
+    $this->users['joelle'] = $this->findUserByUsername('joelle');
+    $this->users['bob'] = $this->findUserByUsername('bob');
+    $this->elements['babylon'] = $this->findOneBy('Element', 'Babylon Pression - Des Tasers et des Pauvres');
+  }
+  
+  protected function createPlaylistWithElement($element)
+  {
+    $this->tests_cases->playlistCreate($element->getId(), 'Playlist de test');
+    $this->assertTrue(!is_null($playlist = $this->findOneBy('Playlist', 'Playlist de test')));
+    return $playlist;
+  }
+  
+}

src/Muzich/CoreBundle/Tests/lib/Security/Context.php

@@ -78,6 +78,39 @@ class Context
       case SecurityContext::ACTION_GET_FAVORITES_TAGS:
         return $this->security_context_tests->getFavoritesTagsResponseIs($success, $condition);
       break;
+      case SecurityContext::ACTION_PLAYLIST_ADD_ELEMENT:
+        return $this->security_context_tests->playlistAddElementResponseIs($success, $condition);
+      break;
+      case SecurityContext::ACTION_PLAYLIST_UPDATE_ORDER:
+        return $this->security_context_tests->playlistUpdateOrderResponseIs($success, $condition);
+      break;
+      case SecurityContext::ACTION_PLAYLIST_REMOVE_ELEMENT:
+        return $this->security_context_tests->playlistRemoveElementResponseIs($success, $condition);
+      break;
+      case SecurityContext::ACTION_PLAYLIST_CREATE:
+        return $this->security_context_tests->playlistCreateResponseIs($success, $condition);
+      break;
+      case SecurityContext::ACTION_PLAYLIST_COPY:
+        return $this->security_context_tests->playlistCopyResponseIs($success, $condition);
+      break;
+      case SecurityContext::ACTION_PLAYLIST_DELETE:
+        return $this->security_context_tests->playlistDeleteResponseIs($success, $condition);
+      break;
+      case SecurityContext::ACTION_PLAYLIST_UNPICK:
+        return $this->security_context_tests->playlistUnpickResponseIs($success, $condition);
+      break;
+      case SecurityContext::ACTION_PLAYLIST_PICK:
+        return $this->security_context_tests->playlistPickResponseIs($success, $condition);
+      break;
+      case SecurityContext::ACTION_PLAYLIST_SHOW:
+        return $this->security_context_tests->playlistShowResponseIs($success, $condition);
+      break;
+      case SecurityContext::ACTION_PLAYLIST_DATA_AUTOPLAY:
+        return $this->security_context_tests->playlistAutoplayResponseIs($success, $condition);
+      break;
+      case SecurityContext::ACTION_PLAYLIST_ADD_PROMPT:
+        return $this->security_context_tests->playlistPromptResponseIs($success, $condition);
+      break;
       default:
         throw new \Exception('Action unknow');
     }

src/Muzich/CoreBundle/Tests/lib/Security/ContextTestCases.php

@@ -5,6 +5,7 @@ namespace Muzich\CoreBundle\Tests\lib\Security;
 use Muzich\CoreBundle\lib\Test\Client;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
 use Muzich\CoreBundle\Security\Context as SecurityContext;
+use Symfony\Component\DomCrawler\Crawler;
 
 class ContextTestCases
 {
@@ -18,7 +19,7 @@ class ContextTestCases
     $this->test = $test;
   }
   
-  private function responseSatisfyConditions($response, $success, $condition)
+  private function ajaxResponseSatisfyConditions($response, $success, $condition)
   {
     $response = json_decode($response, true);
     
@@ -45,6 +46,25 @@ class ContextTestCases
     return false;
   }
   
+  private function responseSatisfyConditions($response, $success, $condition, $user)
+  {
+    if (($response->getStatusCode() == 200 || $response->getStatusCode() == 302) && $success)
+    {
+      return true;
+    }
+    
+    if (($response->getStatusCode() != 302 && $response->getStatusCode() != 302) && !$success)
+    {
+      $security_context = new SecurityContext($user);
+      if ($condition && !$security_context->userIsInThisCondition($condition))
+      {
+        return false;
+      }
+      
+      return true;
+    }
+  }
+  
   public function getAjaxRequestContentResponse($method, $url, $parameters = array())
   {
     $this->test->getClient()->request(
@@ -56,7 +76,7 @@ class ContextTestCases
   
   public function addElementResponseIs($success, $condition)
   {
-    return $this->responseSatisfyConditions(
+    return $this->ajaxResponseSatisfyConditions(
       $this->getAjaxRequestContentResponse(
         'POST',
         $this->test->generateUrl('element_add', array('_locale' => 'fr'))
@@ -68,7 +88,7 @@ class ContextTestCases
   
   public function noteElementResponseIs($success, $condition)
   {
-    return $this->responseSatisfyConditions(
+    return $this->ajaxResponseSatisfyConditions(
       $this->getAjaxRequestContentResponse(
         'GET',
         $this->test->generateUrl('ajax_element_add_vote_good', array(
@@ -83,7 +103,7 @@ class ContextTestCases
   
   public function alertCommentResponseIs($success, $condition)
   {
-    return $this->responseSatisfyConditions(
+    return $this->ajaxResponseSatisfyConditions(
       $this->getAjaxRequestContentResponse(
         'GET',
         $this->test->generateUrl('ajax_alert_comment', array(
@@ -99,7 +119,7 @@ class ContextTestCases
   
   public function alertElementResponseIs($success, $condition)
   {
-    return $this->responseSatisfyConditions(
+    return $this->ajaxResponseSatisfyConditions(
       $this->getAjaxRequestContentResponse(
         'GET',
         $this->test->generateUrl('ajax_report_element', array(
@@ -114,7 +134,7 @@ class ContextTestCases
   
   public function addTagResponseIs($success, $condition)
   {
-    return $this->responseSatisfyConditions(
+    return $this->ajaxResponseSatisfyConditions(
       $this->getAjaxRequestContentResponse(
         'POST',
         $this->test->generateUrl('ajax_add_tag'),
@@ -127,7 +147,7 @@ class ContextTestCases
   
   public function proposeElementTagsResponseIs($success, $condition)
   {
-    return $this->responseSatisfyConditions(
+    return $this->ajaxResponseSatisfyConditions(
       $this->getAjaxRequestContentResponse(
         'POST',
         $this->test->generateUrl('ajax_element_propose_tags_proceed', 
@@ -161,26 +181,17 @@ class ContextTestCases
       array()
     );
     
-    if ($this->test->getClient()->getResponse()->getStatusCode() == 200 && $success)
-    {
-      return true;
-    }
-    
-    if ($this->test->getClient()->getResponse()->getStatusCode() != 200 && !$success)
-    {
-      $security_context = new SecurityContext($this->test->getUser());
-      if ($condition && !$security_context->userIsInThisCondition($condition))
-      {
-        return false;
-      }
-      
-      return true;
-    }
+    return $this->responseSatisfyConditions(
+      $this->test->getClient()->getResponse(), 
+      $success, 
+      $condition, 
+      $this->test->getUser()
+    );
   }
   
   public function addCommentResponseIs($success, $condition)
   {
-    return $this->responseSatisfyConditions(
+    return $this->ajaxResponseSatisfyConditions(
       $this->getAjaxRequestContentResponse(
         'POST',
         $this->test->generateUrl('ajax_add_comment', array(
@@ -195,7 +206,7 @@ class ContextTestCases
   
   public function addElementToFavoriteResponseIs($success, $condition)
   {
-    return $this->responseSatisfyConditions(
+    return $this->ajaxResponseSatisfyConditions(
       $this->getAjaxRequestContentResponse(
         'GET',
         $this->test->generateUrl('favorite_add', array(
@@ -210,7 +221,7 @@ class ContextTestCases
   
   public function followUserResponseIs($success, $condition)
   {
-    return $this->responseSatisfyConditions(
+    return $this->ajaxResponseSatisfyConditions(
       $this->getAjaxRequestContentResponse(
         'GET',
         $this->test->generateUrl('follow', array(
@@ -226,7 +237,7 @@ class ContextTestCases
   
   public function getFavoritesTagsResponseIs($success, $condition)
   {
-    return $this->responseSatisfyConditions(
+    return $this->ajaxResponseSatisfyConditions(
       $this->getAjaxRequestContentResponse(
         'GET',
         $this->test->generateUrl('ajax_get_favorites_tags', array(
@@ -238,4 +249,220 @@ class ContextTestCases
     );
   }
   
+  public function playlistAddElementResponseIs($success, $condition)
+  {
+    return $this->ajaxResponseSatisfyConditions(
+      $this->getAjaxRequestContentResponse(
+        'GET',
+        $this->test->generateUrl('playlists_add_element', array(
+          'playlist_id' => 0,
+          'element_id'  => 0,
+          '_locale'     => 'fr'
+        ))
+      ), 
+      $success, 
+      $condition
+    );
+  }
+  
+  public function playlistUpdateOrderResponseIs($success, $condition)
+  {
+    return $this->ajaxResponseSatisfyConditions(
+      $this->getAjaxRequestContentResponse(
+        'GET',
+        $this->test->generateUrl('playlist_update_order', array(
+          'playlist_id' => 0,
+          '_locale'     => 'fr'
+        ))
+      ), 
+      $success, 
+      $condition
+    );
+  }
+  
+  public function playlistRemoveElementResponseIs($success, $condition)
+  {
+    return $this->ajaxResponseSatisfyConditions(
+      $this->getAjaxRequestContentResponse(
+        'GET',
+        $this->test->generateUrl('playlist_remove_element', array(
+          'playlist_id' => 0,
+          'element_id'  => 0,
+          '_locale'     => 'fr'
+        ))
+      ), 
+      $success, 
+      $condition
+    );
+  }
+  
+  public function playlistCreateResponseIs($success, $condition)
+  {
+    $this->playlistCreate(0, 'my_super_playlist');
+    return $this->ajaxResponseSatisfyConditions(
+      $this->test->getClient()->getResponse()->getContent(),
+      $success, 
+      $condition
+    );
+  }
+  
+  public function playlistCreate($element_id, $playlist_name)
+  {
+    $this->test->goToPage($this->test->generateUrl('playlists_add_element_prompt', array(
+      'element_id'  => $element_id,
+      '_locale'     => 'fr'
+    )));
+    
+    $response = json_decode($this->test->client->getResponse()->getContent(), true);
+    $crawler = new Crawler($response['data']);
+    
+    $extract = $crawler->filter('input[name="playlist[_token]"]')
+      ->extract(array('value'));
+    $csrf = $extract[0];
+    
+    $this->test->crawler = $this->test->client->request(
+      'POST', 
+      $this->test->generateUrl('playlist_add_element_and_create', array(
+        'element_id'  => $element_id,
+        '_locale'     => 'fr'
+      )), 
+      array(
+        'playlist' => array(
+          'name'   => $playlist_name,
+          '_token' => $csrf
+        )
+      ),
+      array(), 
+      array('HTTP_X-Requested-With' => 'XMLHttpRequest')
+    );
+  }
+
+
+  public function playlistCopyResponseIs($success, $condition)
+  {
+    return $this->ajaxResponseSatisfyConditions(
+      $this->getAjaxRequestContentResponse(
+        'GET',
+        $this->test->generateUrl('playlists_add_element_and_copy', array(
+          'playlist_id' => 0,
+          'element_id'  => 0,
+          '_locale'     => 'fr'
+        ))
+      ), 
+      $success, 
+      $condition
+    );
+  }
+  
+  public function playlistDeleteResponseIs($success, $condition)
+  {
+    $this->test->getClient()->request(
+      'GET', 
+      $this->test->generateUrl('playlist_delete', array(
+          'playlist_id' => 0,
+          'element_id'  => 0,
+          '_locale'     => 'fr'
+        )), 
+      array(), 
+      array(), 
+      array()
+    );
+    
+    return $this->responseSatisfyConditions(
+      $this->test->getClient()->getResponse(), 
+      $success, 
+      $condition, 
+      $this->test->getUser()
+    );
+  }
+  
+  public function playlistUnpickResponseIs($success, $condition)
+  {
+    return $this->ajaxResponseSatisfyConditions(
+      $this->getAjaxRequestContentResponse(
+        'GET',
+        $this->test->generateUrl('playlist_unpick', array(
+          'playlist_id' => 0,
+          '_locale'     => 'fr'
+        ))
+      ), 
+      $success, 
+      $condition
+    );
+  }
+  
+  public function playlistPickResponseIs($success, $condition)
+  {
+    return $this->ajaxResponseSatisfyConditions(
+      $this->getAjaxRequestContentResponse(
+        'GET',
+        $this->test->generateUrl('playlist_pick', array(
+          'playlist_id' => 0,
+          '_locale'     => 'fr'
+        ))
+      ), 
+      $success, 
+      $condition
+    );
+  }
+  
+  public function playlistShowResponseIs($success, $condition)
+  {
+    $this->playlistShow('bux', 0);
+    
+    return $this->responseSatisfyConditions(
+      $this->test->getClient()->getResponse(), 
+      $success, 
+      $condition, 
+      $this->test->getUser()
+    );
+  }
+  
+  public function playlistsShow($user_slug)
+  {
+    $this->test->goToPage($this->test->generateUrl('playlists_user', array(
+      'user_slug'   => $user_slug,
+      '_locale'     => 'fr'
+    )));
+  }
+  
+  public function playlistShow($user_slug, $playlist_id)
+  {
+    $this->test->goToPage($this->test->generateUrl('playlist', array(
+      'user_slug'   => $user_slug,
+      'playlist_id' => $playlist_id,
+      '_locale'     => 'fr'
+    )));
+  }
+  
+  public function playlistAutoplayResponseIs($success, $condition)
+  {
+    return $this->ajaxResponseSatisfyConditions(
+      $this->getAjaxRequestContentResponse(
+        'GET',
+        $this->test->generateUrl('playlist_datas_for_autoplay', array(
+          'playlist_id' => 0,
+          '_locale'     => 'fr'
+        ))
+      ), 
+      $success, 
+      $condition
+    );
+  }
+  
+  public function playlistPromptResponseIs($success, $condition)
+  {
+    return $this->ajaxResponseSatisfyConditions(
+      $this->getAjaxRequestContentResponse(
+        'GET',
+        $this->test->generateUrl('playlists_add_element_prompt', array(
+          'element_id' => 0,
+          '_locale'    => 'fr'
+        ))
+      ), 
+      $success, 
+      $condition
+    );
+  }
+  
 }

src/Muzich/CoreBundle/lib/FunctionalTest.php

@@ -16,13 +16,13 @@ class FunctionalTest extends WebTestCase
    *
    * @var Client 
    */
-  protected $client;
+  public $client;
   
   /**
    *
    * @var Crawler 
    */
-  protected $crawler;
+  public $crawler;
   
   public function getClient()
   {
@@ -34,7 +34,7 @@ class FunctionalTest extends WebTestCase
     return $this->crawler;
   }
   
-  protected function outputDebug($content = null)
+  public function outputDebug($content = null)
   {
     $time = time();
     //unlink('.debug/out'.$time.'.html');
@@ -353,7 +353,7 @@ class FunctionalTest extends WebTestCase
   {
     $this->assertTrue($this->crawler->filter($filter)->count() > 0);
   }
-  
+    
   /**
    * Test l'inexistance d'un element
    * 

src/Muzich/PlaylistBundle/Controller/EditController.php

@@ -100,7 +100,7 @@ class EditController extends Controller
   public function deleteAction($playlist_id)
   {
     if (($uncondition = $this->userHaveNonConditionToMakeAction(SecurityContext::ACTION_PLAYLIST_DELETE)) !== false)
-      return $this->jsonResponseError($uncondition);
+      throw $this->createNotFoundException();
     
     if (!($playlist = $this->getPlaylistManager()->findOwnedPlaylistWithId($playlist_id, $this->getUser())))
       throw $this->createNotFoundException();

src/Muzich/PlaylistBundle/Resources/views/Show/user.html.twig

@@ -8,7 +8,7 @@
   {% if playlists|length %}
   <ul class="playlists">
     {% for playlist in playlists %}
-      <li>
+      <li class="playlist">
         
         <a class="autoplay_playlist" href="{{ path('playlist_datas_for_autoplay', { 'playlist_id' : playlist.id }) }}" >
           Lire