correction of some bugs with moving objects and first revision of readme

tracim/tracim/lib/webdav/README.txt

@@ -0,0 +1,49 @@
+## What is webdav ?
+
+Webdav's a extension of the HTTP protocol that introduces new requests (MKCOL, PROPFIND...) to ease the
+management of files on a distant server. More information can be found [here](https://tools.ietf.org/html/rfc4918).
+
+This project is based on the project [WSGIDav](https://github.com/mar10/wsgidav), which is an implementation of webdav in python that
+provides all basic needs to install a webdav on your server. This library intends to adapt WSGIDav implementation
+with the database based file management of Tracim, allowing users to access and modify files through their
+Window's file system.
+
+## Behavior to know about Windows' client and Webdav
+
+There are behaviors you may observe while using the windows' client for webdav which differ from other clients.
+
+* Window's will send twice each request. The first one as Anonymous, which will get a 401 Not Authorized, and then
+the second authentified which will proceed normally. This is the correct behavior that you have to observe for every webdav's client.
+In fact when sending
+The thing is that you'll observe only one request for clients like Debian's default filesystem because they cache the first response
+they got when sending an Anonymous request and they know that they have to send an authentication, thus they don't waste time sending
+twice the request.
+
+* When uploading new documents, windows will call twice put if the files does not exist. The first one with a length of 0 so that the resources
+can be locked before sending the whole file.
+
+* To display names, Windows won't use the displayName property but the object's path. Thus even if /a/b/c can link to a file named 'readme.txt' with
+   other webdav's client, you'll need to have a path named '/a/b/readme.txt' with Windows' client.
+
+## Known issues
+
+As for now, there's still some flaws or unexpected behaviors in the webdav implementation when using Windows' client.
+Though we could - and may - use github's issues to report them, we'll first write them down here to not pollute the
+original reports on tracim's _normal use_.
+
+* When moving files or folders from webdav to webdav, windows will warn you that this action may harm your computer. Though it won't say anything
+when moving files from your computer to webdav or vice-versa.
+
+* When deleting folders, Windows will go through all sub-folders and files recursively and request to delete them itself before going back to the main
+target. In our case it means it'll delete all sub-contents in database when we only want the parent to be in _deleted state_.
+Plus as a folder is _never empty_ (always contains .deleted and .archived) it won't even delete the folder because it'll first check if the target
+isn't empty before sending the final delete request.
+
+* Lock/unlock system is currently broken, thus it's not possible to work with office as it'll lock both the document and its temporary files and
+will be unable to unlock afterward, making it impossible to update them and making windows make a lot of unwanted request because the first failed.
+**Imma gonna correct it asap**.
+
+## Improving performances
+
+All request aren't still optimal and may take longer than what we want or expect. Here will be some tracks that will ease
+code refactoring to improve performances.

tracim/tracim/lib/webdav/sql_dav_provider.py

@@ -49,6 +49,9 @@ class Provider(DAVProvider):
         """
         Called by wsgidav whenever a request is called to get the _DAVResource corresponding to the path
         """
+        if not self.exists(path, environ):
+            return None
+
         path = normpath(path)
         root_path = environ['http_authenticator.realm']
 
@@ -63,6 +66,8 @@ class Provider(DAVProvider):
         # If the request path is in the form root/name, then we return a Workspace resource
         parent_path = dirname(path)
         if parent_path == root_path:
+            if not workspace:
+                return None
             return sql_resources.Workspace(path, environ, workspace)
 
         # And now we'll work on the path to establish which type or resource is requested
@@ -151,7 +156,7 @@ class Provider(DAVProvider):
 
         workspace = self.get_workspace_from_path(path, WorkspaceApi(user))
 
-        if parent_path == root_path:
+        if parent_path == root_path or workspace is None:
             return workspace is not None
 
         content_api = ContentApi(user, show_archived=True, show_deleted=True)

tracim/tracim/lib/webdav/sql_resources.py

@@ -199,6 +199,7 @@ class Workspace(DAVCollection):
         return self.workspace.label
 
     def getLastModified(self) -> float:
+        print("hm....", self.path)
         return mktime(self.workspace.updated.timetuple())
 
     def getMemberNames(self) -> [str]:
@@ -579,10 +580,11 @@ class HistoryFolder(Folder):
             children = self.content_api.get_all(None, ContentType.Any, self.workspace)
         
         for content in children:
-            members.append(HistoryFileFolder(
-                path='%s/%s' % (self.path, content.get_label()),
-                environ=self.environ,
-                content=content))
+            if content.is_archived == self._is_archived and content.is_deleted == self._is_deleted:
+                members.append(HistoryFileFolder(
+                    path='%s/%s' % (self.path, content.get_label()),
+                    environ=self.environ,
+                    content=content))
 
         return members
 
@@ -647,16 +649,17 @@ class DeletedFolder(HistoryFolder):
             children = self.content_api.get_all(None, ContentType.Any, self.workspace)
 
         for content in children:
-            content_path = '%s/%s' % (self.path, self.provider.transform_to_display(content.get_label()))
+            if content.is_deleted:
+                content_path = '%s/%s' % (self.path, self.provider.transform_to_display(content.get_label()))
 
-            if content.type == ContentType.Folder:
-                members.append(Folder(content_path, self.environ, self.workspace, content))
-            elif content.type == ContentType.File:
-                self._file_count += 1
-                members.append(File(content_path, self.environ, content))
-            else:
-                self._file_count += 1
-                members.append(OtherFile(content_path, self.environ, content))
+                if content.type == ContentType.Folder:
+                    members.append(Folder(content_path, self.environ, self.workspace, content))
+                elif content.type == ContentType.File:
+                    self._file_count += 1
+                    members.append(File(content_path, self.environ, content))
+                else:
+                    self._file_count += 1
+                    members.append(OtherFile(content_path, self.environ, content))
 
         if self._file_count > 0 and self.provider.show_history():
             members.append(
@@ -726,16 +729,17 @@ class ArchivedFolder(HistoryFolder):
             children = self.content_api.get_all(None, ContentType.Any, self.workspace)
 
         for content in children:
-            content_path = '%s/%s' % (self.path, self.provider.transform_to_display(content.get_label()))
+            if content.is_archived:
+                content_path = '%s/%s' % (self.path, self.provider.transform_to_display(content.get_label()))
 
-            if content.type == ContentType.Folder:
-                members.append(Folder(content_path, self.environ, self.workspace, content))
-            elif content.type == ContentType.File:
-                self._file_count += 1
-                members.append(File(content_path, self.environ, content))
-            else:
-                self._file_count += 1
-                members.append(OtherFile(content_path, self.environ, content))
+                if content.type == ContentType.Folder:
+                    members.append(Folder(content_path, self.environ, self.workspace, content))
+                elif content.type == ContentType.File:
+                    self._file_count += 1
+                    members.append(File(content_path, self.environ, content))
+                else:
+                    self._file_count += 1
+                    members.append(OtherFile(content_path, self.environ, content))
 
         if self._file_count > 0 and self.provider.show_history():
             members.append(
@@ -932,17 +936,19 @@ class File(DAVNonCollection):
             raise DAVError(HTTP_FORBIDDEN)
 
     def move_file(self, destpath):
-        parent = self.provider.get_parent_from_path(
+
+        workspace = self.provider.get_workspace_from_path(
             normpath(destpath),
-            self.content_api,
             WorkspaceApi(self.user)
         )
 
-        workspace = self.provider.get_workspace_from_path(
+        parent = self.provider.get_parent_from_path(
             normpath(destpath),
-            WorkspaceApi(self.user)
+            self.content_api,
+            workspace
         )
 
+
         with new_revision(self.content):
             if basename(destpath) != self.getDisplayName():
                 self.content_api.update_content(self.content, re.sub('\.[^\.]+$', '', self.provider.transform_to_bdd(basename(destpath))))