bugfix: do not save thread description update when both label and description keep the same

tracim/tracim/controllers/__init__.py

@@ -23,6 +23,7 @@ from tracim.model.data import Workspace
 
 from tracim.lib.content import ContentApi
 from tracim.lib.user import UserStaticApi
+from tracim.lib.utils import SameValueError
 
 from tracim.model.serializers import Context
 from tracim.model.serializers import DictLikeClass
@@ -248,6 +249,11 @@ class TIMWorkspaceContentRestController(TIMRestControllerWithBreadcrumb):
             tg.flash(msg, CST.STATUS_OK)
             tg.redirect(self._std_url.format(tmpl_context.workspace_id, tmpl_context.folder_id, item.content_id))
 
+        except SameValueError as e:
+            msg = _('{} not updated: the content did not change').format(self._item_type_label)
+            tg.flash(msg, CST.STATUS_WARNING)
+            tg.redirect(self._err_url.format(tmpl_context.workspace_id, tmpl_context.folder_id, item_id))
+
         except ValueError as e:
             msg = _('{} not updated - error: {}').format(self._item_type_label, str(e))
             tg.flash(msg, CST.STATUS_ERROR)

tracim/tracim/controllers/content.py

@@ -18,6 +18,7 @@ from tracim.controllers import TIMWorkspaceContentRestController
 from tracim.lib import CST
 from tracim.lib.base import BaseController
 from tracim.lib.base import logger
+from tracim.lib.utils import SameValueError
 from tracim.lib.content import ContentApi
 from tracim.lib.helpers import convert_id_into_instances
 from tracim.lib.predicates import current_user_is_reader
@@ -426,6 +427,11 @@ class UserWorkspaceFolderPageRestController(TIMWorkspaceContentRestController):
             tg.flash(msg, CST.STATUS_OK)
             tg.redirect(self._std_url.format(tmpl_context.workspace_id, tmpl_context.folder_id, item.content_id))
 
+        except SameValueError as e:
+            msg = _('{} not updated: the content did not change').format(self._item_type_label)
+            tg.flash(msg, CST.STATUS_WARNING)
+            tg.redirect(self._err_url.format(tmpl_context.workspace_id, tmpl_context.folder_id, item_id))
+
         except ValueError as e:
             msg = _('{} not updated - error: {}').format(self._item_type_label, str(e))
             tg.flash(msg, CST.STATUS_ERROR)

tracim/tracim/lib/content.py

@@ -15,6 +15,7 @@ from sqlalchemy import not_
 from sqlalchemy import or_
 from tracim.lib import cmp_to_key
 from tracim.lib.notifications import NotifierFactory
+from tracim.lib.utils import SameValueError
 from tracim.model import DBSession
 from tracim.model.auth import User
 from tracim.model.data import ActionDescription
@@ -335,6 +336,8 @@ class ContentApi(object):
 
 
     def update_content(self, item: Content, new_label: str, new_content: str=None) -> Content:
+        if item.label==new_label and item.description==new_content:
+            raise SameValueError(_('The content did not changed'))
         item.owner = self._user
         item.label = new_label
         item.description = new_content if new_content else item.description # TODO: convert urls into links

tracim/tracim/lib/utils.py

@@ -15,3 +15,6 @@ def exec_time_monitor():
         return wrapper_func
     return decorator_func
 
+
+class SameValueError(ValueError):
+    pass