Adding management of mail sending error in debug trace and frontend flash message while creating user

tracim/tracim/controllers/admin/user.py

@@ -344,12 +344,20 @@ class UserRestController(TIMRestController):
 
         api.save(user)
 
+        email_sent = True
         if send_email:
             email_manager = get_email_manager()
-            email_manager.notify_created_account(user, password=password)
+            try:
+                email_manager.notify_created_account(user, password=password)
+            except Exception:
+                email_sent = False
 
         api.execute_created_user_actions(user)
-        tg.flash(_('User {} created.').format(user.get_display_name()), CST.STATUS_OK)
+        if not email_sent:
+            tg.flash(_('User {0} created but email was not sent to {1}').format(user.get_display_name(), user.email),
+                     CST.STATUS_WARNING)
+        else:
+            tg.flash(_('User {} created.').format(user.get_display_name()), CST.STATUS_OK)
         tg.redirect(self.url())
 
     @classmethod

tracim/tracim/lib/email.py

@@ -69,6 +69,7 @@ class EmailSender(object):
             logger.info(self, 'Connecting from SMTP server {}'.format(self._smtp_config.server))
             self._smtp_connection = smtplib.SMTP(self._smtp_config.server, self._smtp_config.port)
             self._smtp_connection.ehlo()
+
             if self._smtp_config.login:
                 try:
                     starttls_result = self._smtp_connection.starttls()
@@ -82,9 +83,12 @@ class EmailSender(object):
                     logger.debug(self, 'SMTP login result: {}'.format(login_res))
                 except Exception as e:
                     logger.debug(self, 'SMTP login error: {}'.format(e.__str__()))
-                
+                    raise e
+
             logger.info(self, 'Connection OK')
 
+
+
     def disconnect(self):
         if self._smtp_connection:
             logger.info(self, 'Disconnecting from SMTP server {}'.format(self._smtp_config.server))
@@ -96,7 +100,7 @@ class EmailSender(object):
         if not self._is_active:
             logger.info(self, 'Not sending email to {} (service desactivated)'.format(message['To']))
         else:
-            self.connect() # Acutally, this connects to SMTP only if required
+            self.connect() # Actually, this connects to SMTP only if required
             logger.info(self, 'Sending email to {}'.format(message['To']))
             self._smtp_connection.send_message(message)