PEP8 + Comments

tracim/tracim/lib/email_fetcher.py

@@ -159,6 +159,7 @@ class MailFetcher(object):
         :param endpoint: tracim http endpoint where decoded mail are send.
         :param token: token to authenticate http connexion
         :param use_html_parsing: parse html mail
+        :param use_txt_parsing: parse txt mail
         """
         self._connection = None
         self.host = host

tracim/tracim/lib/email_processing/checkers.py

@@ -48,20 +48,21 @@ class HtmlChecker(object):
         :param attribute_value: Html attribute value
         :return: True only if Element contain this attribute.
         """
-        if isinstance(elem, Tag) and \
-              attribute_name in elem.attrs:
-              # INFO - G.M - 2017-12-01 - attrs[value}] can be string or list
-              # use get_attribute_list to always check in a list
-              # see https://www.crummy.com/software/BeautifulSoup/bs4/doc/#multi-valued-attributes # nopep8
-            values_lower=[value.lower()
+        if isinstance(elem, Tag) and attribute_name in elem.attrs:
+            # INFO - G.M - 2017-12-01 - attrs[value}] can be string or list
+            # use get_attribute_list to always check in a list
+            # see https://www.crummy.com/software/BeautifulSoup/bs4/doc/#multi-valued-attributes # nopep8
+            values_lower = [value.lower()
                             for value
-                            in elem.get_attribute_list(attribute_name) ]
+                            in elem.get_attribute_list(attribute_name)]
             return attribute_value.lower() in values_lower
         return False
 
 
 class HtmlMailQuoteChecker(HtmlChecker):
-
+    """
+    Check if one HTML Element from Body Mail look-like a quote or not.
+    """
     @classmethod
     def is_quote(
             cls,
@@ -145,6 +146,9 @@ class HtmlMailQuoteChecker(HtmlChecker):
 
 
 class HtmlMailSignatureChecker(HtmlChecker):
+    """
+    Check if one HTML Element from Body Mail look-like a signature or not.
+    """
 
     @classmethod
     def is_signature(
@@ -205,4 +209,3 @@ class HtmlMailSignatureChecker(HtmlChecker):
                 ProprietaryHTMLAttrValues.Outlook_com_signature_id):
             return True
         return False
-

tracim/tracim/tests/library/test_email_body_parser.py

@@ -116,6 +116,7 @@ class TestHtmlMailSignatureChecker(TestStandard):
         assert HtmlMailSignatureChecker._is_outlook_com_signature(main_elem) \
                is True
 
+
 class TestBodyMailsParts(TestStandard):
 
     def test_unit__std_list_methods(self):
@@ -162,7 +163,7 @@ class TestBodyMailsParts(TestStandard):
     def test_unit__append_dont_follow_when_first(self):
         mail_parts = BodyMailParts()
         a = BodyMailPart('a', BodyMailPartType.Main)
-        mail_parts._append(a,follow=True)
+        mail_parts._append(a, follow=True)
         assert len(mail_parts) == 1
         assert mail_parts[0].part_type == BodyMailPartType.Main
         assert mail_parts[0].text == 'a'
@@ -223,7 +224,6 @@ class TestBodyMailsParts(TestStandard):
         assert mail_parts[0].text == 'ac'
         assert mail_parts[0].part_type == BodyMailPartType.Main
 
-
     def test_unit__get_nb_part_type(self):
         mail_parts = BodyMailParts()
         assert mail_parts.get_nb_part_type(BodyMailPartType.Main) == 0
@@ -542,7 +542,7 @@ class TestParsedMail(TestStandard):
         écrit&nbsp;:<br>
         </div>
         <blockquote type="cite"
-        cite="mid:4e6923e2-796d-eccf-84b7-6824da4151ee@localhost.fr">Réponse <br>
+        cite="mid:4e6923e2-796d-eccf-84b7-6824da4151ee@localhost.fr">Réponse<br>
         <br>
         Le 28/11/2017 à 11:21, John Doe a écrit&nbsp;: <br>
         <blockquote type="cite"> <br>
@@ -755,4 +755,3 @@ class TestParsedMail(TestStandard):
         assert elements[0].part_type == BodyMailPartType.Main
         assert elements[1].part_type == BodyMailPartType.Signature
         assert elements[2].part_type == BodyMailPartType.Quote
-