Browse Source

better comments for jitsi-meet templates

Guénaël Muller 6 years ago
parent
commit
daea087e18
1 changed files with 7 additions and 15 deletions
  1. 7 15
      tracim/tracim/templates/videoconf/jitsi_meet.mak

+ 7 - 15
tracim/tracim/templates/videoconf/jitsi_meet.mak View File

38
     </div>
38
     </div>
39
     <script src="https://${jitsi_meet_room.domain}/libs/external_api.min.js"></script>
39
     <script src="https://${jitsi_meet_room.domain}/libs/external_api.min.js"></script>
40
     <script>
40
     <script>
41
-        //This example use jitsi-external API. Using lib-jitsi-meet is also a possibility.
42
-        // It support alls jitsi-meet features.
43
-        // About support for "private (1-to-1) text message into room", check this :
44
-        // https://github.com/jitsi/lib-jitsi-meet/pull/616
45
         let domain = '${jitsi_meet_room.domain}';
41
         let domain = '${jitsi_meet_room.domain}';
46
         let options = {
42
         let options = {
47
-	    // jitsi-meet support now(10-2017) only one way to auto-auth, token,
48
-	    // which is anonymous BOSH auth with specific url (with token value in params of the url).
43
+	    // INFO - G.M - 14-02-2018 jitsi-meet external API
44
+        // support only one way to auto-auth due to security concern : token,
45
+	    // which is anonymous BOSH auth with specific url
46
+        // for another way to deal with auto-auth :
47
+        // see this rejected PR : https://github.com/jitsi/jitsi-meet/pull/2109
49
             %if jitsi_meet_room.use_token:
48
             %if jitsi_meet_room.use_token:
50
                 jwt: '${jitsi_meet_room.generate_token()}',
49
                 jwt: '${jitsi_meet_room.generate_token()}',
51
             %endif
50
             %endif
52
             roomName : '${jitsi_meet_room.room}',
51
             roomName : '${jitsi_meet_room.room}',
53
             parentNode: document.querySelector('#jitsi'),
52
             parentNode: document.querySelector('#jitsi'),
54
-            // has external API use iframe, height is a problem
53
+            // TODO - G.M - 14-02-2018 - Find a solution to height trouble.
54
+            // height should be related to page size
55
             height: 700,
55
             height: 700,
56
             no_SSL: true,
56
             no_SSL: true,
57
             configOverwrite: {
57
             configOverwrite: {
58
                  enableWelcomePage: false,
58
                  enableWelcomePage: false,
59
                  enableUserRolesBasedOnToken: true,
59
                  enableUserRolesBasedOnToken: true,
60
-                // Example of how it can be possible to use others auths.
61
-                // This solution has some security issue.
62
-                // see this rejected PR : https://github.com/jitsi/jitsi-meet/pull/2109
63
-                // roomPassword: "plop",
64
-                // userJid: "john@auth.prosody",
65
-                // userPassword: "j",
66
-
67
             },
60
             },
68
             interfaceConfigOverwrite: {
61
             interfaceConfigOverwrite: {
69
-                // DEFAULT_BACKGROUND: '#FFFFFF',
70
                 SHOW_JITSI_WATERMARK: false,
62
                 SHOW_JITSI_WATERMARK: false,
71
                 SHOW_POWERED_BY: false,
63
                 SHOW_POWERED_BY: false,
72
                 SHOW_WATERMARK_FOR_GUESTS: false,
64
                 SHOW_WATERMARK_FOR_GUESTS: false,