Browse Source

catch generic exception generated by preview generator

Damien Accorsi 7 years ago
parent
commit
f85e69dea2
1 changed files with 13 additions and 1 deletions
  1. 13 1
      tracim/tracim/controllers/content.py

+ 13 - 1
tracim/tracim/controllers/content.py View File

241
         except PreviewGeneratorException as e:
241
         except PreviewGeneratorException as e:
242
             # INFO - A.P - Silently intercepts preview exception
242
             # INFO - A.P - Silently intercepts preview exception
243
             # As preview generation isn't mandatory, just register it
243
             # As preview generation isn't mandatory, just register it
244
-            logger.debug(self, 'Exception: {}'.format(e.__str__))
244
+            logger.debug(
245
+                self,
246
+                'Preview Generator Exception: {}'.format(e.__str__)
247
+            )
248
+        except Exception as e:
249
+            # INFO - D.A - 2017-08-11 - Make Tracim robust to pg exceptions
250
+            # Preview generator may potentially raise any type of exception
251
+            # so we prevent user interface crashes by catching all exceptions
252
+            logger.error(
253
+                self,
254
+                'Preview Generator Generic Exception: {}'.format(e.__str__)
255
+            )
256
+
245
         pdf_available = 'true' if enable_pdf_buttons else 'false'  # type: str
257
         pdf_available = 'true' if enable_pdf_buttons else 'false'  # type: str
246
 
258
 
247
         fake_api_breadcrumb = self.get_breadcrumb(file_id)
259
         fake_api_breadcrumb = self.get_breadcrumb(file_id)