Anomalie #816: Err 500 getOne

app/Resources/translations/elements.en.yml

@@ -9,6 +9,8 @@ noelements:
   
   sentence_filter_link_string: delete them.
   
+  nofound_anymore:      Share not found (maybe deleted by owner)
+  
 element:
   favorite:
     add:                Add to faves

app/Resources/translations/elements.fr.yml

@@ -8,6 +8,7 @@ noelements:
                          <br />Vous pouvez ajouter des tags ou
                          <a class="filter_clear_url" href="#" >%link_string%</a>.
   sentence_filter_link_string: les retirer
+  nofound_anymore:      Le partage est introuvable (il peut avoir été supprimé par son auteur)
   
 element:
   favorite:

src/Muzich/CoreBundle/Controller/ElementController.php

@@ -1085,8 +1085,10 @@ class ElementController extends Controller
     if (!($element = $es->getElements($this->getDoctrine(), $this->getUserId(true), 'single')))
     {
       return $this->jsonResponse(array(
-      'status'  => 'error'
-    ));
+        self::RESPONSE_STATUS_ID  => self::RESPONSE_STATUS_ERROR,
+        self::RESPONSE_ERROR_ID   => self::ERROR_TYPE_NOTFOUND,
+        self::RESPONSE_MESSAGE_ID => $this->trans('noelements.nofound_anymore', array(), 'elements')
+      ));
     }
     
     $html = $this->render('MuzichCoreBundle:SearchElement:li.element.html.twig', array(

src/Muzich/CoreBundle/Resources/public/js/muzich.js

@@ -3141,10 +3141,16 @@ $(document).ready(function(){
           function(){}
         );
 
+        line.find('img.loader').hide();
         if (response.status === 'success')
         {
           line.find('div.content_opened').html('<ul class="elements">' + response.data + '</ul>');
         }
+        else
+        if (response.status === 'error')
+        {
+          line.find('div.content_opened').html(response.message);
+        }
       });
     }
     else

src/Muzich/CoreBundle/Searcher/ElementSearcher.php

@@ -3,6 +3,7 @@
 namespace Muzich\CoreBundle\Searcher;
 
 use Doctrine\Bundle\DoctrineBundle\Registry;
+use Doctrine\ORM\NoResultException;
 
 class ElementSearcher extends Searcher implements SearcherInterface
 {
@@ -341,7 +342,15 @@ class ElementSearcher extends Searcher implements SearcherInterface
       break;
     
       case 'single':
-        return $query->getSingleResult();
+        try
+        {
+          return $query->getSingleResult();
+        } 
+        catch (NoResultException $exc)
+        {
+          return null;
+        }
+        
       break;
     
       default :

src/Muzich/CoreBundle/lib/Controller.php

@@ -20,6 +20,14 @@ use Muzich\CoreBundle\Form\Playlist\PlaylistForm;
 class Controller extends BaseController
 {
   
+  const RESPONSE_STATUS_ID = 'status';
+  const RESPONSE_ERROR_ID = 'error';
+  const RESPONSE_MESSAGE_ID = 'message';
+  const RESPONSE_STATUS_ERROR = 'error';
+  
+  const ERROR_TYPE_NOTFOUND = 'notfound';
+  const ERROR_TYPE_MUSTBECONNECTED = 'mustbeconnected';
+  
   protected static $user = null;
   protected static $user_personal_query = null;
   protected static $tags = array();