浏览代码

Tightens tests queries to avoid false negative

Adrien Panay 7 年前
父节点
当前提交
8bf343699d
共有 2 个文件被更改,包括 8 次插入4 次删除
  1. 6 3
      tracim/tracim/tests/functional/test_calendar.py
  2. 2 1
      tracim/tracim/tests/models/test_content.py

+ 6 - 3
tracim/tracim/tests/functional/test_calendar.py 查看文件

@@ -21,6 +21,7 @@ from tracim.tests import TestCalendar as BaseTestCalendar
21 21
 from tracim.tests import not_raises
22 22
 from tracim.model.auth import User
23 23
 from tracim.model.data import Content
24
+from tracim.model.data import ContentRevisionRO
24 25
 from tracim.model.data import Workspace
25 26
 
26 27
 
@@ -197,9 +198,11 @@ END:VCALENDAR
197 198
         time.sleep(3)  # Wait for be sure transaction commited in daemon
198 199
         transaction.commit()
199 200
         try:
200
-            event = DBSession.query(Content).filter(
201
-                Content.label == 'This is an event'
202
-            ).one()
201
+            event = DBSession.query(Content) \
202
+                .filter(Content.label == 'This is an event') \
203
+                .filter(Content.owner_id == lawrence.user_id) \
204
+                .filter(Content.id == ContentRevisionRO.content_id) \
205
+                .one()
203 206
         except NoResultFound:
204 207
             ok_(False, 'Content record should exist for '
205 208
                        '"This is an event" label')

+ 2 - 1
tracim/tracim/tests/models/test_content.py 查看文件

@@ -53,7 +53,8 @@ class TestContent(TestStandard):
53 53
             .join(ContentRevisionRO, and_(Content.id == ContentRevisionRO.content_id,
54 54
                                           ContentRevisionRO.revision_id == join_sub_query))
55 55
 
56
-        eq_(2, base_query.count())
56
+        pattern = 'TEST_CONTENT_DESCRIPTION_%_UPDATED'
57
+        eq_(2, base_query.filter(Content.description.like(pattern)).count())
57 58
 
58 59
         eq_(1, base_query.filter(Content.workspace == workspace1).count())
59 60
         eq_(1, base_query.filter(Content.workspace == workspace2).count())