Browse Source

Tightens tests queries to avoid false negative

Adrien Panay 7 years ago
parent
commit
8bf343699d

+ 6 - 3
tracim/tracim/tests/functional/test_calendar.py View File

21
 from tracim.tests import not_raises
21
 from tracim.tests import not_raises
22
 from tracim.model.auth import User
22
 from tracim.model.auth import User
23
 from tracim.model.data import Content
23
 from tracim.model.data import Content
24
+from tracim.model.data import ContentRevisionRO
24
 from tracim.model.data import Workspace
25
 from tracim.model.data import Workspace
25
 
26
 
26
 
27
 
197
         time.sleep(3)  # Wait for be sure transaction commited in daemon
198
         time.sleep(3)  # Wait for be sure transaction commited in daemon
198
         transaction.commit()
199
         transaction.commit()
199
         try:
200
         try:
200
-            event = DBSession.query(Content).filter(
201
-                Content.label == 'This is an event'
202
-            ).one()
201
+            event = DBSession.query(Content) \
202
+                .filter(Content.label == 'This is an event') \
203
+                .filter(Content.owner_id == lawrence.user_id) \
204
+                .filter(Content.id == ContentRevisionRO.content_id) \
205
+                .one()
203
         except NoResultFound:
206
         except NoResultFound:
204
             ok_(False, 'Content record should exist for '
207
             ok_(False, 'Content record should exist for '
205
                        '"This is an event" label')
208
                        '"This is an event" label')

+ 2 - 1
tracim/tracim/tests/models/test_content.py View File

53
             .join(ContentRevisionRO, and_(Content.id == ContentRevisionRO.content_id,
53
             .join(ContentRevisionRO, and_(Content.id == ContentRevisionRO.content_id,
54
                                           ContentRevisionRO.revision_id == join_sub_query))
54
                                           ContentRevisionRO.revision_id == join_sub_query))
55
 
55
 
56
-        eq_(2, base_query.count())
56
+        pattern = 'TEST_CONTENT_DESCRIPTION_%_UPDATED'
57
+        eq_(2, base_query.filter(Content.description.like(pattern)).count())
57
 
58
 
58
         eq_(1, base_query.filter(Content.workspace == workspace1).count())
59
         eq_(1, base_query.filter(Content.workspace == workspace1).count())
59
         eq_(1, base_query.filter(Content.workspace == workspace2).count())
60
         eq_(1, base_query.filter(Content.workspace == workspace2).count())