fix preview endpoint + test related

tracim/lib/core/content.py

@@ -748,7 +748,7 @@ class ContentApi(object):
                     content_id=content_id
                 ),
             )
-        jpg_preview_path = self.preview_manager.get_jpeg_preview(
+        jpg_preview_path = self.preview_manager.get_pdf_preview(
             file_path,
             page=page
         )
@@ -769,6 +769,7 @@ class ContentApi(object):
             self._config.PREVIEW_JPG_RESTRICTED_DIMS,
             self._config.PREVIEW_JPG_ALLOWED_DIMS,
         )
+
     def get_jpg_preview_path(
         self,
         content_id: int,

tracim/tests/functional/test_contents.py

@@ -1459,6 +1459,206 @@ class TestFiles(FunctionalTest):
             status=400
         )
 
+    def test_api__get_pdf_preview__ok__200__nominal_case(self) -> None:
+        """
+        get full pdf preview of a txt file
+        """
+        dbsession = get_tm_session(self.session_factory, transaction.manager)
+        admin = dbsession.query(models.User) \
+            .filter(models.User.email == 'admin@admin.admin') \
+            .one()
+        workspace_api = WorkspaceApi(
+            current_user=admin,
+            session=dbsession,
+            config=self.app_config
+        )
+        content_api = ContentApi(
+            current_user=admin,
+            session=dbsession,
+            config=self.app_config
+        )
+        business_workspace = workspace_api.get_one(1)
+        tool_folder = content_api.get_one(1, content_type=ContentType.Any)
+        test_file = content_api.create(
+            content_type=ContentType.File,
+            workspace=business_workspace,
+            parent=tool_folder,
+            label='Test file',
+            do_save=True,
+            do_notify=False,
+        )
+        with new_revision(
+                session=dbsession,
+                tm=transaction.manager,
+                content=test_file,
+        ):
+            test_file.file_extension = '.txt'
+            test_file.depot_file = FileIntent(
+                b'Test file',
+                'Test_file.txt',
+                'text/plain',
+            )
+            content_api.update_content(test_file, 'Test_file', '<p>description</p>')
+        dbsession.flush()
+        transaction.commit()
+        content_id = int(test_file.content_id)
+        self.testapp.authorization = (
+            'Basic',
+            (
+                'admin@admin.admin',
+                'admin@admin.admin'
+            )
+        )
+        res = self.testapp.put(
+            '/api/v2/workspaces/1/files/{}/raw'.format(content_id),
+            upload_files=[
+                ('files', test_file.file_name, test_file.depot_file.file.read())
+            ],
+            status=204,
+        )
+        params = {'page': 0}
+        res = self.testapp.get(
+            '/api/v2/workspaces/1/files/{}/preview/pdf'.format(content_id),
+            status=200,
+            params=params,
+        )
+        assert res.content_type == 'application/pdf'
+
+    def test_api__get_pdf_preview__ok__err__400_page_of_preview_not_found(self) -> None:
+        """
+        get full pdf preview of a txt file
+        """
+        dbsession = get_tm_session(self.session_factory, transaction.manager)
+        admin = dbsession.query(models.User) \
+            .filter(models.User.email == 'admin@admin.admin') \
+            .one()
+        workspace_api = WorkspaceApi(
+            current_user=admin,
+            session=dbsession,
+            config=self.app_config
+        )
+        content_api = ContentApi(
+            current_user=admin,
+            session=dbsession,
+            config=self.app_config
+        )
+        business_workspace = workspace_api.get_one(1)
+        tool_folder = content_api.get_one(1, content_type=ContentType.Any)
+        test_file = content_api.create(
+            content_type=ContentType.File,
+            workspace=business_workspace,
+            parent=tool_folder,
+            label='Test file',
+            do_save=True,
+            do_notify=False,
+        )
+        with new_revision(
+                session=dbsession,
+                tm=transaction.manager,
+                content=test_file,
+        ):
+            test_file.file_extension = '.txt'
+            test_file.depot_file = FileIntent(
+                b'Test file',
+                'Test_file.txt',
+                'text/plain',
+            )
+            content_api.update_content(test_file, 'Test_file', '<p>description</p>')
+        dbsession.flush()
+        transaction.commit()
+        content_id = int(test_file.content_id)
+        self.testapp.authorization = (
+            'Basic',
+            (
+                'admin@admin.admin',
+                'admin@admin.admin'
+            )
+        )
+        res = self.testapp.put(
+            '/api/v2/workspaces/1/files/{}/raw'.format(content_id),
+            upload_files=[
+                ('files', test_file.file_name, test_file.depot_file.file.read())
+            ],
+            status=204,
+        )
+        params = {'page': 1}
+        res = self.testapp.get(
+            '/api/v2/workspaces/1/files/{}/preview/pdf'.format(content_id),
+            status=400,
+            params=params,
+        )
+
+    def test_api__get_pdf_revision_preview__ok__200__nominal_case(self) -> None:
+        """
+        get pdf revision preview of content
+        """
+        dbsession = get_tm_session(self.session_factory, transaction.manager)
+        admin = dbsession.query(models.User) \
+            .filter(models.User.email == 'admin@admin.admin') \
+            .one()
+        workspace_api = WorkspaceApi(
+            current_user=admin,
+            session=dbsession,
+            config=self.app_config
+        )
+        content_api = ContentApi(
+            current_user=admin,
+            session=dbsession,
+            config=self.app_config
+        )
+        business_workspace = workspace_api.get_one(1)
+        tool_folder = content_api.get_one(1, content_type=ContentType.Any)
+        test_file = content_api.create(
+            content_type=ContentType.File,
+            workspace=business_workspace,
+            parent=tool_folder,
+            label='Test file',
+            do_save=False,
+            do_notify=False,
+        )
+        test_file.file_extension = '.txt'
+        test_file.depot_file = FileIntent(
+            b'Test file',
+            'Test_file.txt',
+            'text/plain',
+        )
+        dbsession.flush()
+        transaction.commit()
+        content_id = int(test_file.content_id)
+        revision_id = int(test_file.revision_id)
+        image = create_test_image()
+        self.testapp.authorization = (
+            'Basic',
+            (
+                'admin@admin.admin',
+                'admin@admin.admin'
+            )
+        )
+        res = self.testapp.put(
+            '/api/v2/workspaces/1/files/{}/raw'.format(content_id),
+            upload_files=[
+                ('files', image.name, image.getvalue())
+            ],
+            status=204,
+        )
+        res = self.testapp.get(
+            '/api/v2/workspaces/1/files/{content_id}/revisions/{revision_id}/raw'.format(
+                content_id=content_id,
+                revision_id=revision_id,
+            ),
+            status=200
+        )
+        assert res.content_type == 'text/plain'
+        params = {'page': 0}
+        res = self.testapp.get(
+            '/api/v2/workspaces/1/files/{content_id}/revisions/{revision_id}/preview/pdf'.format(
+                content_id=content_id,
+                revision_id=revision_id,
+            ),
+            status=200
+        )
+        assert res.content_type == 'application/pdf'
+
 
 class TestThreads(FunctionalTest):
     """

tracim/views/contents_api/file_controller.py

@@ -36,6 +36,7 @@ from tracim.models.contents import ContentTypeLegacy as ContentType
 from tracim.models.contents import file_type
 from tracim.models.revision_protection import new_revision
 from tracim.exceptions import EmptyLabelNotAllowed
+from tracim.exceptions import PageOfPreviewNotFound
 from tracim.exceptions import PreviewDimNotAllowed
 
 FILE_ENDPOINTS_TAG = 'Files'
@@ -130,6 +131,7 @@ class FileController(Controller):
     @require_workspace_role(UserRoleInWorkspace.READER)
     @require_content_types([file_type])
     @hapic.handle_exception(UnavailablePreviewType, HTTPStatus.BAD_REQUEST)
+    @hapic.handle_exception(PageOfPreviewNotFound, HTTPStatus.BAD_REQUEST)
     @hapic.input_query(PageQuerySchema())
     @hapic.input_path(WorkspaceAndContentIdPathSchema())
     @hapic.output_file([])
@@ -204,6 +206,7 @@ class FileController(Controller):
     @hapic.with_api_doc(tags=[FILE_ENDPOINTS_TAG])
     @require_workspace_role(UserRoleInWorkspace.READER)
     @require_content_types([file_type])
+    @hapic.handle_exception(PageOfPreviewNotFound, HTTPStatus.BAD_REQUEST)
     @hapic.input_path(WorkspaceAndContentIdPathSchema())
     @hapic.input_query(PageQuerySchema())
     @hapic.output_file([])
@@ -231,6 +234,7 @@ class FileController(Controller):
     @hapic.with_api_doc(tags=[FILE_ENDPOINTS_TAG])
     @require_workspace_role(UserRoleInWorkspace.READER)
     @require_content_types([file_type])
+    @hapic.handle_exception(PageOfPreviewNotFound, HTTPStatus.BAD_REQUEST)
     @hapic.handle_exception(PreviewDimNotAllowed, HTTPStatus.BAD_REQUEST)
     @hapic.input_query(PageQuerySchema())
     @hapic.input_path(ContentPreviewSizedPathSchema())
@@ -258,6 +262,7 @@ class FileController(Controller):
     @hapic.with_api_doc(tags=[FILE_ENDPOINTS_TAG])
     @require_workspace_role(UserRoleInWorkspace.READER)
     @require_content_types([file_type])
+    @hapic.handle_exception(PageOfPreviewNotFound, HTTPStatus.BAD_REQUEST)
     @hapic.handle_exception(PreviewDimNotAllowed, HTTPStatus.BAD_REQUEST)
     @hapic.input_path(RevisionPreviewSizedPathSchema())
     @hapic.input_query(PageQuerySchema())