Merge pull request #77 from tracim/fix/59_global_exception_handling

setup.py

@@ -24,7 +24,7 @@ requires = [
     'zope.sqlalchemy',
     'alembic',
     # API
-    'hapic',
+    'hapic>=0.41',
     'marshmallow <3.0.0a1,>2.0.0',
     # CLI
     'cliff',

tracim/__init__.py

@@ -5,6 +5,8 @@ import time
 from pyramid.config import Configurator
 from pyramid.authentication import BasicAuthAuthenticationPolicy
 from hapic.ext.pyramid import PyramidContext
+from pyramid.exceptions import NotFound
+from sqlalchemy.exc import OperationalError
 
 from tracim.extensions import hapic
 from tracim.config import CFG
@@ -52,12 +54,15 @@ def web(global_config, **local_settings):
     # Add SqlAlchemy DB
     configurator.include('.models')
     # set Hapic
-    hapic.set_context(
-        PyramidContext(
-            configurator=configurator,
-            default_error_builder=ErrorSchema()
-        )
+    context = PyramidContext(
+        configurator=configurator,
+        default_error_builder=ErrorSchema(),
+        debug=app_config.DEBUG,
     )
+    hapic.set_context(context)
+    context.handle_exception(NotFound, 404)
+    context.handle_exception(OperationalError, 500)
+    context.handle_exception(Exception, 500)
     # Add controllers
     session_api = SessionController()
     configurator.include(session_api.bind, route_prefix=BASE_API_V2)

tracim/config.py

@@ -128,6 +128,7 @@ class CFG(object):
             '604800',
         ))
 
+        self.DEBUG = asbool(settings.get('debug', False))
         # TODO - G.M - 27-03-2018 - [Email] Restore email config
         ###
         # EMAIL related stuff (notification, reply)

tracim/tests/functional/test_session.py

@@ -17,8 +17,6 @@ class TestLogoutEndpoint(FunctionalTest):
 
 class TestLoginEndpointUnititedDB(FunctionalTestNoDB):
 
-    @pytest.mark.xfail(raises=OperationalError,
-                       reason='Not supported yet by hapic')
     def test_api__try_login_enpoint__err_500__no_inited_db(self):
         params = {
             'email': 'admin@admin.admin',