add tests for user, permission and controller models

tracim/tests/models/test_controller.py

@@ -0,0 +1,16 @@
+# coding=utf-8
+import pytest
+from pyramid.config import Configurator
+
+from tracim.views.controllers import Controller
+
+
+class TestControllerModel(object):
+    """
+    Test for Controller object
+    """
+    def test_unit__bind__err__not_implemented(self):
+        controller = Controller()
+        configurator = Configurator()
+        with pytest.raises(NotImplementedError):
+            controller.bind(configurator)

tracim/tests/models/test_permission.py

@@ -0,0 +1,51 @@
+# coding=utf-8
+import transaction
+from tracim.tests import eq_
+from tracim.tests import BaseTest
+from tracim.models.auth import Permission
+
+
+class TestPermissionModel(BaseTest):
+    """
+    Test for permission model
+    """
+    def test_unit__create__ok__nominal_case(self):
+        self.session.flush()
+        transaction.commit()
+
+        name = 'my_permission'
+        description = 'my_perm_description'
+        permission = Permission()
+        permission.permission_name = name
+        permission.description = description
+
+        self.session.add(permission)
+        self.session.flush()
+        transaction.commit()
+
+        new_permission = self.session.query(Permission).filter(permission.permission_name == name).one()  # nopep8
+
+        assert new_permission.permission_name == name
+        assert new_permission.description == description
+        assert new_permission.permission_id
+        assert isinstance(new_permission.permission_id, int)
+        # TODO - G.M -24-05-2018 - Do test for groups
+
+    def test_unit__repr__ok__nominal_case(self):
+        name = 'my_permission'
+        description = 'my_perm_description'
+        permission = Permission()
+        permission.permission_name = name
+        permission.description = description
+
+        assert permission.__repr__() == "<Permission: name='my_permission'>"
+
+    def test_unit__unicode__ok__nominal_case(self):
+        name = 'my_permission'
+        description = 'my_perm_description'
+        permission = Permission()
+        permission.permission_name = name
+        permission.description = description
+
+        assert permission.__unicode__() == name
+

tracim/tests/models/test_user.py

@@ -1,15 +1,15 @@
 # -*- coding: utf-8 -*-
-import transaction
 
-from tracim.tests import eq_
+import transaction
 from tracim.tests import BaseTest
-
 from tracim.models.auth import User
 
 
 class TestUserModel(BaseTest):
-
-    def test_create(self):
+    """
+    Test for User model
+    """
+    def test_unit__create__ok__nominal_case(self):
         self.session.flush()
         transaction.commit()
         name = 'Damien'
@@ -23,13 +23,49 @@ class TestUserModel(BaseTest):
         self.session.flush()
         transaction.commit()
 
-        new_user = self.session.query(User).filter(User.display_name==name).one()
+        new_user = self.session.query(User).filter(User.display_name == name).one()  # nopep8
+
+        assert new_user.display_name == name
+        assert new_user.email == email
+        assert new_user.email_address == email
+
+    def test_unit__password__ok__nominal_case(self):
+        """
+        Check if password can be set and hashed password
+        can be retrieve. Verify if hashed password is not
+        same as password.
+        """
+        name = 'Damien'
+        email = 'tracim@trac.im'
+        password = 'my_secure_password'
+
+        user = User()
+        user.display_name = name
+        user.email = email
+        assert user._password is None
+        user.password = password
+        assert user._password is not None
+        assert user._password != password
+        assert user.password == user._password
+
+    def test__unit__validate_password__ok__nominal_case(self):
+        """
+        Check if validate_password can correctly check if password i the correct
+        one
+        """
 
-        eq_(new_user.display_name, name)
-        eq_(new_user.email, email)
-        eq_(new_user.email_address, email)
+        name = 'Damien'
+        email = 'tracim@trac.im'
+        password = 'my_secure_password'
+
+        user = User()
+        user.display_name = name
+        user.email = email
+        user.password = password
+
+        assert user.validate_password(password) is True
 
-    def test_null_password(self):
+    def test_unit__validate_password__false__null_password(self):
         # Check bug #70 fixed
         # http://tracim.org/workspaces/4/folders/5/threads/70
 
@@ -40,4 +76,49 @@ class TestUserModel(BaseTest):
         user.display_name = name
         user.email = email
 
-        eq_(False, user.validate_password(None))
+        assert user.validate_password('') is False
+
+    def test_unit__validate_password__false__bad_password(self):
+        """
+        Check if validate_password can correctly check if password is
+        an uncorrect correct one
+        """
+        name = 'Damien'
+        email = 'tracim@trac.im'
+        password = 'my_secure_password'
+
+        user = User()
+        user.display_name = name
+        user.email = email
+        user.password = password
+
+        assert user.validate_password('uncorrect_password') is False
+
+    def test_unit__repr__ok__nominal_case(self):
+        name = 'Damien'
+        email = 'tracim@trac.im'
+
+        user = User()
+        user.display_name = name
+        user.email = email
+
+        assert user.__repr__() == "<User: email='tracim@trac.im', display='Damien'>"  # nopep8
+
+    def test_unit__unicode__ok__nominal_case(self):
+        name = 'Damien'
+        email = 'tracim@trac.im'
+
+        user = User()
+        user.display_name = name
+        user.email = email
+
+        assert user.__unicode__() == name
+
+    def test__unit__unicode__ok__no_display_name(self):
+
+        email = 'tracim@trac.im'
+
+        user = User()
+        user.email = email
+
+        assert user.__unicode__() == email