Browse Source

require candidate workspace_role decorator do not allow empty value

Guénaël Muller 6 years ago
parent
commit
ab4fc62011
1 changed files with 2 additions and 5 deletions
  1. 2 5
      tracim/lib/utils/authorization.py

+ 2 - 5
tracim/lib/utils/authorization.py View File

@@ -106,7 +106,7 @@ def require_workspace_role(minimal_required_role: int):
106 106
 def require_candidate_workspace_role(minimal_required_role: int):
107 107
     """
108 108
     Decorator for view to restrict access of tracim request if role
109
-    is not high enough. Do nothing is candidate_workspace_role is not found.
109
+    is not high enough.
110 110
     :param minimal_required_role: value from UserInWorkspace Object like
111 111
     UserRoleInWorkspace.CONTRIBUTOR or UserRoleInWorkspace.READER
112 112
     :return: decorator
@@ -115,10 +115,7 @@ def require_candidate_workspace_role(minimal_required_role: int):
115 115
 
116 116
         def wrapper(self, context, request: 'TracimRequest'):
117 117
             user = request.current_user
118
-            try:
119
-                workspace = request.candidate_workspace
120
-            except WorkspaceNotFoundInTracimRequest:
121
-                return func(self, context, request)
118
+            workspace = request.candidate_workspace
122 119
 
123 120
             if workspace.get_user_role(user) >= minimal_required_role:
124 121
                 return func(self, context, request)