add exception case for contents

tracim/__init__.py

@@ -33,7 +33,9 @@ from tracim.exceptions import InsufficientUserProfile
 from tracim.exceptions import InsufficientUserRoleInWorkspace
 from tracim.exceptions import WorkspaceNotFoundInTracimRequest
 from tracim.exceptions import UserNotFoundInTracimRequest
+from tracim.exceptions import ContentNotFoundInTracimRequest
 from tracim.exceptions import WorkspaceNotFound
+from tracim.exceptions import ContentNotFound
 from tracim.exceptions import UserDoesNotExist
 from tracim.exceptions import AuthenticationFailed
 from tracim.exceptions import ContentTypeNotAllowed
@@ -83,8 +85,10 @@ def web(global_config, **local_settings):
     # Bad request
     context.handle_exception(WorkspaceNotFoundInTracimRequest, HTTPStatus.BAD_REQUEST)  # nopep8
     context.handle_exception(UserNotFoundInTracimRequest, HTTPStatus.BAD_REQUEST)  # nopep8
+    context.handle_exception(ContentNotFoundInTracimRequest, HTTPStatus.BAD_REQUEST)  # nopep8
     context.handle_exception(WorkspaceNotFound, HTTPStatus.BAD_REQUEST)
     context.handle_exception(UserDoesNotExist, HTTPStatus.BAD_REQUEST)
+    context.handle_exception(ContentNotFound, HTTPStatus.BAD_REQUEST)
     context.handle_exception(ContentTypeNotAllowed, HTTPStatus.BAD_REQUEST)
     # Auth exception
     context.handle_exception(NotAuthenticated, HTTPStatus.UNAUTHORIZED)

tracim/tests/functional/test_contents.py

@@ -13,22 +13,6 @@ class TestHtmlDocuments(FunctionalTest):
 
     fixtures = [BaseFixture, ContentFixtures]
 
-    def test_api__get_html_document__err_400__wrong_content_type(self) -> None:
-        """
-        Get one html document of a content
-        """
-        self.testapp.authorization = (
-            'Basic',
-            (
-                'admin@admin.admin',
-                'admin@admin.admin'
-            )
-        )
-        res = self.testapp.get(
-            '/api/v2/workspaces/2/html-documents/7',
-            status=400
-        )   # nopep8
-
     def test_api__get_html_document__ok_200__legacy_slug(self) -> None:
         """
         Get one html document of a content
@@ -44,7 +28,7 @@ class TestHtmlDocuments(FunctionalTest):
         res = self.testapp.get(
             '/api/v2/workspaces/2/html-documents/6',
             status=200
-        )   # nopep8
+        )
         content = res.json_body
         assert content['content_type'] == 'html-documents'
         assert content['content_id'] == 6
@@ -85,7 +69,7 @@ class TestHtmlDocuments(FunctionalTest):
         res = self.testapp.get(
             '/api/v2/workspaces/2/html-documents/6',
             status=200
-        )   # nopep8
+        )
         content = res.json_body
         assert content['content_type'] == 'html-documents'
         assert content['content_id'] == 6
@@ -112,6 +96,70 @@ class TestHtmlDocuments(FunctionalTest):
         assert content['last_modifier']['avatar_url'] is None
         assert content['raw_content'] == '<p>To cook a great Tiramisu, you need many ingredients.</p>'  # nopep8
 
+    def test_api__get_html_document__err_400__wrong_content_type(self) -> None:
+        """
+        Get one html document of a content content 7 is not html_document
+        """
+        self.testapp.authorization = (
+            'Basic',
+            (
+                'admin@admin.admin',
+                'admin@admin.admin'
+            )
+        )
+        res = self.testapp.get(
+            '/api/v2/workspaces/2/html-documents/7',
+            status=400
+        )
+
+    def test_api__get_html_document__err_400__content_does_not_exist(self) -> None:  # nopep8
+        """
+        Get one html document of a content (content 170 does not exist in db
+        """
+        self.testapp.authorization = (
+            'Basic',
+            (
+                'admin@admin.admin',
+                'admin@admin.admin'
+            )
+        )
+        res = self.testapp.get(
+            '/api/v2/workspaces/2/html-documents/170',
+            status=400
+        )
+
+    def test_api__get_html_document__err_400__content_not_in_workspace(self) -> None:  # nopep8
+        """
+        Get one html document of a content (content 6 is in workspace 2)
+        """
+        self.testapp.authorization = (
+            'Basic',
+            (
+                'admin@admin.admin',
+                'admin@admin.admin'
+            )
+        )
+        res = self.testapp.get(
+            '/api/v2/workspaces/1/html-documents/6',
+            status=400
+        )
+
+    def test_api__get_html_document__err_400__workspace_does_not_exist(self) -> None:  # nopep8
+        """
+        Get one html document of a content (Workspace 40 does not exist)
+        """
+        self.testapp.authorization = (
+            'Basic',
+            (
+                'admin@admin.admin',
+                'admin@admin.admin'
+            )
+        )
+        res = self.testapp.get(
+            '/api/v2/workspaces/40/html-documents/6',
+            status=400
+        )
+
     def test_api__update_html_document__ok_200__nominal_case(self) -> None:
         """
         Update(put) one html document of a content
@@ -158,7 +206,7 @@ class TestHtmlDocuments(FunctionalTest):
         res = self.testapp.get(
             '/api/v2/workspaces/2/html-documents/6',
             status=200
-        )   # nopep8
+        )
         content = res.json_body
         assert content['content_type'] == 'html-documents'
         assert content['content_id'] == 6
@@ -284,7 +332,7 @@ class TestHtmlDocuments(FunctionalTest):
         res = self.testapp.get(
             '/api/v2/workspaces/2/html-documents/6',
             status=200
-        )   # nopep8
+        )
         content = res.json_body
         assert content['content_type'] == 'html-documents'
         assert content['content_id'] == 6
@@ -301,7 +349,7 @@ class TestHtmlDocuments(FunctionalTest):
         res = self.testapp.get(
             '/api/v2/workspaces/2/html-documents/6',
             status=200
-        )   # nopep8
+        )
         content = res.json_body
         assert content['content_type'] == 'html-documents'
         assert content['content_id'] == 6
@@ -330,7 +378,7 @@ class TestThreads(FunctionalTest):
         res = self.testapp.get(
             '/api/v2/workspaces/2/threads/6',
             status=400
-        )   # nopep8
+        )
 
     def test_api__get_thread__ok_200__nominal_case(self) -> None:
         """
@@ -373,9 +421,57 @@ class TestThreads(FunctionalTest):
         assert content['last_modifier']['avatar_url'] is None
         assert content['raw_content'] == 'What is the best cake?'  # nopep8
 
+    def test_api__get_thread__err_400__content_does_not_exist(self) -> None:
+        """
+        Get one thread (content 170 does not exist)
+        """
+        self.testapp.authorization = (
+            'Basic',
+            (
+                'admin@admin.admin',
+                'admin@admin.admin'
+            )
+        )
+        res = self.testapp.get(
+            '/api/v2/workspaces/2/threads/170',
+            status=400
+        )
+
+    def test_api__get_thread__err_400__content_not_in_workspace(self) -> None:
+        """
+        Get one thread(content 7 is in workspace 2)
+        """
+        self.testapp.authorization = (
+            'Basic',
+            (
+                'admin@admin.admin',
+                'admin@admin.admin'
+            )
+        )
+        res = self.testapp.get(
+            '/api/v2/workspaces/1/threads/7',
+            status=400
+        )
+
+    def test_api__get_thread__err_400__workspace_does_not_exist(self) -> None:  # nopep8
+        """
+        Get one thread (Workspace 40 does not exist)
+        """
+        self.testapp.authorization = (
+            'Basic',
+            (
+                'admin@admin.admin',
+                'admin@admin.admin'
+            )
+        )
+        res = self.testapp.get(
+            '/api/v2/workspaces/40/threads/7',
+            status=400
+        )
+
     def test_api__update_thread__ok_200__nominal_case(self) -> None:
         """
-        Update(put) one html document of a content
+        Update(put) thread
         """
         self.testapp.authorization = (
             'Basic',
@@ -447,7 +543,7 @@ class TestThreads(FunctionalTest):
             self
     ) -> None:
         """
-        Get one html document of a content
+        Get threads revisions
         """
         self.testapp.authorization = (
             'Basic',
@@ -505,7 +601,7 @@ class TestThreads(FunctionalTest):
 
     def test_api__set_thread_status__ok_200__nominal_case(self) -> None:
         """
-        Get one html document of a content
+        Set thread status
         """
         self.testapp.authorization = (
             'Basic',